Merged
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments (1)
- apps/36-blocks/src/app/users/management/management.component.html (19-19) The overflow-hidden property was removed from the main content area div. This might cause unwanted scrolling or content overflow in certain scenarios. Consider keeping this property unless there's a specific reason for removing it.
💡 To request another review, post a new comment with "/windsurf-review".
| <mat-slide-toggle | ||
| [formControl]="featureForm.get('serviceDetails')?.at(row.index)?.get('is_enable')" | ||
| color="primary" | ||
| disabled="true" |
There was a problem hiding this comment.
The disabled attribute should use property binding syntax for Angular Material components.
Suggested change
| disabled="true" | |
| [disabled]="true" |
|
|
||
| <ng-template #configureMethodFormContent let-serviceForm="serviceForm"> | ||
| <div class="flex flex-col grow card-with-header" [class.border]="!serviceForm"> | ||
| <div class="flex flex-col grow" [class]="!serviceForm ? 'border card-with-header' : ''"> |
There was a problem hiding this comment.
Consider using Angular's more readable class binding syntax:
Suggested change
| <div class="flex flex-col grow" [class]="!serviceForm ? 'border card-with-header' : ''"> | |
| <div class="flex flex-col grow" [ngClass]="{'border card-with-header': !serviceForm}"> |
| </div> | ||
| } @if (serviceForm ?? featureForm.get('serviceDetails')?.at(selectedServiceIndex); as formToUse) { | ||
| <div class="bg-color flex flex-col gap-3" [class.p-4]="!serviceForm"> | ||
| <div class="flex flex-col gap-3" [class]="!serviceForm ? 'p-4 bg-color' : ''"> |
There was a problem hiding this comment.
Consider using Angular's more readable class binding syntax:
Suggested change
| <div class="flex flex-col gap-3" [class]="!serviceForm ? 'p-4 bg-color' : ''"> | |
| <div class="flex flex-col gap-3" [ngClass]="{'p-4 bg-color': !serviceForm}"> |
dvCodeWorld
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.